Remove/repair tokudb_pk_insert_mode to be safe and deprecate

Description

In 5.7, the new server default of RBR might conflict with the documented default behavior of tokudb_pk_insert_mode=1.

Environment

None

Activity

Show:
George Lorch
April 5, 2016, 4:41 PM

Upon further investigation, the documentation is a bit incorrect. The TokuDB SE with tokudb_pk_insert_mode=1 is safe in all conditions. On INSERT IGNORE or REPLACE INTO, it tests to see if triggers exist on the table, or replication is active with !BINLOG_FORMAT_STMT before it allows the optimization. If either of these conditions are met, then it falls back to the 'safe' operation of looking up the target row first.

We have decided to eliminate the 'unsafe' option entirely starting in 5.6 and deprecate the option as a whole in 5.7, leaving the standard behavior of mode 1 (optimize when/where safe) in place.

In 5.6, a warning will be generated if a user attempts to set the mode to 0 and the mode will be set back to 1.

George Lorch
April 8, 2016, 6:30 PM

Documentation needs updating to something like...

5.6:

5.7:

Assignee

George Lorch

Reporter

George Lorch

Labels

External issue ID

None

Freshdesk Tickets

None

Priority

Major
Configure